post in admin page of addon does not work since commit 30140589c

Mon, 22 Aug 2022 11:48:31 -0400 last edited: Wed, 24 Aug 2022 09:24:07 -0400 from streams

@mike (mike@unfediverse.com)

I pulled the dev today.

The admin page of my addon shows but the post does not work anymore (submit button).

I went back to previous commits and found that commit 3623e8a01 works and the next one 30140589c does not work.

A difference between the too is line 27 in Addon.php

$func($a);

versus

$func();

Is this a bug or a feature?

addons

Giac El Vecio

Mon, 22 Aug 2022 12:24:08 -0400 from Diversi Spiritus

is Addons.php ;)

Giac El Vecio

Mon, 22 Aug 2022 12:46:59 -0400 from Diversi Spiritus

is the line 173 in
Code/Module/Admin/Site.php ok?

"set_config('system', 'force_queue_threshold', $force_queue);"

Giac El Vecio

Mon, 22 Aug 2022 12:49:33 -0400 from Diversi Spiritus

shouldn't it be
"set_config('system', 'force_queue_threshold', $force_queue_threshold);"
?

mike

Mon, 22 Aug 2022 16:21:24 -0400 from y

Just woke up. I'll sort it out as soon as some caffeine makes it to the brain.

mike

Mon, 22 Aug 2022 16:55:22 -0400 from y

OK. Should be good again. Thanks for the report. That was a change my IDE recommended and I thought it was dubious, but went along with it.

These days I have to rely on the IDE to catch some things for me; because sometimes I simply can't remember why some line of code that's 5-10 years old was written a certain way.

The force_queue setting is actually correct, although I agree the code looks wrong.

Einer von Vielen

Wed, 24 Aug 2022 06:57:12 -0400 from streams

tested. ok

Thanks